On 02/28/2014 10:04 AM, Xiubo Li wrote:
Signed-off-by: Xiubo Li Li.Xiubo@freescale.com
@Mark, @Lars, @All,
I have checked for each driver about the following issue from Lars:
"Just removing the set_cache_io() call will not work for all drivers. There are some MFD child devices which use regmap from the parent device. So dev_get_regmap() will return NULL for those."
And they are all fine for me but without testing.
For the CODECs that using MFD will split into another patch.
Looks good in general, but try to build these kinds of changes with CONFIG_COMPILE_TEST=y and CONFIG_SND_SOC_ALL_CODECS=y before sending the patch. There are a lot of warnings about unused variables caused by this patch.
sound/soc/codecs/ad193x.c: In function 'ad193x_codec_probe': sound/soc/codecs/ad193x.c:343:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/adau1373.c: In function 'adau1373_probe': sound/soc/codecs/adau1373.c:1379:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/adav80x.c: In function 'adav80x_probe': sound/soc/codecs/adav80x.c:804:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/ak4535.c: In function 'ak4535_probe': sound/soc/codecs/ak4535.c:392:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/ak4535.c:391:22: warning: unused variable 'ak4535' [-Wunused-variable] sound/soc/codecs/ak4641.c: In function 'ak4641_probe': sound/soc/codecs/ak4641.c:522:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/ak4642.c: In function 'ak4642_probe': sound/soc/codecs/ak4642.c:468:6: warning: unused variable 'ret' [-Wunused- sound/soc/codecs/ak4671.c: In function 'ak4671_probe': sound/soc/codecs/ak4671.c:620:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/cs42l52.c: In function 'cs42l52_probe': sound/soc/codecs/cs42l52.c:1125:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/cs42l73.c: In function 'cs42l73_probe': sound/soc/codecs/cs42l73.c:1363:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/da7210.c: In function 'da7210_probe': sound/soc/codecs/da7210.c:1074:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/da7213.c: In function 'da7213_probe': sound/soc/codecs/da7213.c:1396:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/da732x.c: In function 'da732x_probe': sound/soc/codecs/da732x.c:1522:1: warning: label 'err' defined but not used [-Wunused-label] sound/soc/codecs/da9055.c: In function 'da9055_probe': sound/soc/codecs/da9055.c:1386:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/max9850.c: In function 'max9850_probe': sound/soc/codecs/max9850.c:315:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/ml26124.c: In function 'ml26124_probe': sound/soc/codecs/ml26124.c:590:23: warning: unused variable 'priv' [-Wunused-variable] sound/soc/codecs/ml26124.c:589:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/rt5631.c: In function 'rt5631_probe': sound/soc/codecs/rt5631.c:1573:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/rt5640.c: In function 'rt5640_probe': sound/soc/codecs/rt5640.c:1939:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/ssm2518.c: In function 'ssm2518_probe': sound/soc/codecs/ssm2518.c:652:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/ssm2518.c:651:18: warning: unused variable 'ssm2518' [-Wunused-variable] sound/soc/codecs/sta32x.c: In function 'sta32x_probe': sound/soc/codecs/sta32x.c:940:1: warning: label 'err' defined but not used [-Wunused-label] sound/soc/codecs/sta529.c: In function 'sta529_probe': sound/soc/codecs/sta529.c:326:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/sta529.c:325:17: warning: unused variable 'sta529' [-Wunused-variable] sound/soc/codecs/tlv320aic23.c: In function 'tlv320aic23_probe': sound/soc/codecs/tlv320aic23.c:562:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8510.c: In function 'wm8510_probe': sound/soc/codecs/wm8510.c:599:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/wm8523.c: In function 'wm8523_probe': sound/soc/codecs/wm8523.c:395:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8728.c: In function 'wm8728_probe': sound/soc/codecs/wm8728.c:236:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/wm8900.c: In function 'wm8900_probe': sound/soc/codecs/wm8900.c:1181:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8903.c: In function 'wm8903_probe': sound/soc/codecs/wm8903.c:1907:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/wm8904.c: In function 'wm8904_probe': sound/soc/codecs/wm8904.c:2051:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8961.c: In function 'wm8961_probe': sound/soc/codecs/wm8961.c:839:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8978.c: In function 'wm8978_probe': sound/soc/codecs/wm8978.c:978:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8988.c: In function 'wm8988_probe': sound/soc/codecs/wm8988.c:813:22: warning: unused variable 'wm8988' [-Wunused-variable] sound/soc/codecs/wm8990.c: In function 'wm8990_probe': sound/soc/codecs/wm8990.c:1292:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8991.c: In function 'wm8991_probe': sound/soc/codecs/wm8991.c:1251:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm8996.c: In function 'wm8996_probe': sound/soc/codecs/wm8996.c:2679:1: warning: label 'err' defined but not used [-Wunused-label] sound/soc/codecs/wm9081.c: In function 'wm9081_probe': sound/soc/codecs/wm9081.c:1278:2: warning: 'ret' is used uninitialized in this function [-Wuninitialized] sound/soc/codecs/wm9090.c: In function 'wm9090_probe': sound/soc/codecs/wm9090.c:526:6: warning: unused variable 'ret' [-Wunused-variable] sound/soc/codecs/wm9090.c:525:22: warning: unused variable 'wm9090' [-Wunused-variable]