Re: [alsa-devel] [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

On Mon, 03 Dec 2018 19:53:39 +0100, Ayman Bagabas wrote:

• if (code == 0x80) {

• acpi_status status;
  

• acpi_handle handle;
  

• unsigned long long result;
  

• union acpi_object args[1];
  

• struct acpi_object_list arg_list = {
  

• 	.pointer = args,
  

• 	.count = ARRAY_SIZE(args),
  

• };
  

• args[0].type = ACPI_TYPE_INTEGER;
  

• args[0].integer.value = 0;
  

• status = acpi_get_handle(NULL, "\\WMI0", &handle);
  

• if (ACPI_FAILURE(status)) {
  

• 	dev_err(&wdev->dev, "Unable to get ACPI handle\n");
  

• 	return;
  

• }
  

• status = acpi_evaluate_integer(NULL, "WQ00", &arg_list, &result);
  

I guess you need to pass handle here? In the earlier version, you passed \WMI0.WQ00, so it worked with NULL handle. But now it's no longer so...

Other than that, it looks OK to me. Reviewed-by: Takashi Iwai tiwai@suse.de

But, you don't need to rush too much. Instead, better to test your own patches and make sure that they really work before submitting the final version.

thanks,

Takashi