On Wed, Dec 16, 2020 at 06:44:24PM +0800, Shengjiu Wang wrote:
From: shengjiu wang shengjiu.wang@nxp.com
When condition ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) is true, then goto fail, the uninitialized variable ret will be returned.
Signed-off-by: shengjiu wang shengjiu.wang@nxp.com Reported-by: kernel test robot lkp@intel.com
sound/soc/fsl/imx-hdmi.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c index 2c2a76a71940..ede4a9ad1054 100644 --- a/sound/soc/fsl/imx-hdmi.c +++ b/sound/soc/fsl/imx-hdmi.c @@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) { dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
ret = -EINVAL;-- 2.17.1
I still see a warning in v5.11-rc3 that is fixed by this patch, is it not going in this release cycle? It is a regression fix, seems like it should.
Cheers, Nathan