Re: [alsa-devel] [PATCH 44/50] sound: usb: caiaq: spin_lock in complete() cleanup

On 11.07.2013 11:06, Ming Lei wrote:

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave().

Cc: Daniel Mack zonque@gmail.com Cc: Jaroslav Kysela perex@perex.cz Cc: Takashi Iwai tiwai@suse.de Cc: alsa-devel@alsa-project.org Signed-off-by: Ming Lei ming.lei@canonical.com

Sound right to me, thanks.

Acked-by: Daniel Mack zonque@gmail.com

---

sound/usb/caiaq/audio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c index 7103b09..e5675ab 100644 --- a/sound/usb/caiaq/audio.c +++ b/sound/usb/caiaq/audio.c @@ -672,10 +672,11 @@ static void read_completed(struct urb *urb) offset += len;

if (len > 0) {

• 	spin_lock(&cdev->spinlock);
  

• 	unsigned long flags;
  

• 	spin_lock_irqsave(&cdev->spinlock, flags);
  fill_out_urb(cdev, out, &out->iso_frame_desc[outframe]);
  read_in_urb(cdev, urb, &urb->iso_frame_desc[frame]);
  

• 	spin_unlock(&cdev->spinlock);
  

• 	spin_unlock_irqrestore(&cdev->spinlock, flags);
  check_for_elapsed_periods(cdev, cdev->sub_playback);
  check_for_elapsed_periods(cdev, cdev->sub_capture);
  send_it = 1;