Re: [PATCH 5/8] edac: ghes: use krealloc_array()

On Tue, Oct 27, 2020 at 01:17:22PM +0100, Bartosz Golaszewski wrote:

From: Bartosz Golaszewski bgolaszewski@baylibre.com

Use the helper that checks for overflows internally instead of manually calculating the size of the new array.

Signed-off-by: Bartosz Golaszewski bgolaszewski@baylibre.com

drivers/edac/ghes_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c index a918ca93e4f7..6d1ddecbf0da 100644 --- a/drivers/edac/ghes_edac.c +++ b/drivers/edac/ghes_edac.c @@ -207,8 +207,8 @@ static void enumerate_dimms(const struct dmi_header *dh, void *arg) if (!hw->num_dimms || !(hw->num_dimms % 16)) { struct dimm_info *new;

• new = krealloc(hw->dimms, (hw->num_dimms + 16) * sizeof(struct dimm_info),
  

• 	        GFP_KERNEL);
  

• new = krealloc_array(hw->dimms, hw->num_dimms + 16,
  

• 		     sizeof(struct dimm_info), GFP_KERNEL);
  

  if (!new) { WARN_ON_ONCE(1); return;

--

Sure, why not.

Acked-by: Borislav Petkov bp@suse.de