On Sat, Mar 12, 2022 at 10:20:21PM +0800, Trevor Wu wrote:
On Thu, 2022-03-10 at 16:18 -0600, Rob Herring wrote:
On Tue, Mar 08, 2022 at 03:24:35PM +0800, Trevor Wu wrote:
This patch adds document for mt8195 board with mt6359, max98390 and rt5682.
Signed-off-by: Trevor Wu trevor.wu@mediatek.com
.../sound/mt8195-mt6359-max98390-rt5682.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mt8195- mt6359-max98390-rt5682.yaml
diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359- max98390-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390- rt5682.yaml new file mode 100644 index 000000000000..7ec14d61b109 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359- max98390-rt5682.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mt8195-mt635...
+$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;...
+title: Mediatek MT8195 with MT6359, MAX98390 and RT5682 ASoC sound card driver
+maintainers:
- Trevor Wu trevor.wu@mediatek.com
+description:
- This binding describes the MT8195 sound card.
+properties:
- compatible:
- const: mediatek,mt8195_mt6359_max98390_rt5682
You have nodes for each of these components, why do we need new compatible string for each combination. You can figure out the combination by looking at each of those nodes.
Second, why does each combination need a new schema doc?
Rob
Hi Rob,
I'm not sure whether I can reuse the old schema doc because of the doc name and compatible string seems to be specifically for the codec combination. If I want to reuse the old schema doc, should I change the doc name or compatible string? Make the naming more general.
It's fine to either leave it named after the first compatible string or rename it if you want.
Rob