On Mon, Dec 04, 2017 at 10:04:57PM -0600, Timur Tabi wrote:
On 12/4/17 2:46 PM, Nicolin Chen wrote:
This patch refines the comments by:
- Removing all out-of-date comments
- Removing all not-so-useful comments
- Unifying the styles of all comments
- Simplifying over-descriptive comments
- Adding comments to improve code readablity
- Moving all register related comments to fsl_ssi.h
- Adding comments to all register and field defines
Even after adding dozens of lines in fsl_ssi.h, this patch reduces 100 lines totally.
I'll review the other patches later, but I'm not keen on your removal of some of the comments in this patch. I don't see why line count is so important, and you're removing some informative text. I
That's okay. That's why I included recent contributors to review.
can see removing trivial comments and outdated ones, but "no-so-useful" and "over-descriptive" are subjective.
I agree. I am just being very aggressive here to clean up the driver in any inch that I feel it's possible to simplify. If any one has a concern about certain parts of the removal, it's okay to justify for it. I will revise it to get more informative while being concise.