On Sun, Mar 10, 2013 at 07:33:08PM +0100, Markus Pargmann wrote:
Add devicetree support for this audio soc fabric driver.
Signed-off-by: Markus Pargmann mpa@pengutronix.de
sound/soc/fsl/phycore-ac97.c | 148 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 125 insertions(+), 23 deletions(-)
A binding document is mandatory for new bindings.
+#ifdef CONFIG_MACH_IMX27_DT
.cpu_dai_name = "10010000.ssi",.platform_name = "imx-fiq-pcm-audio",+#else
This looks wrong, at least the CPU DAI name should be being looked up via the DT.
+static const struct of_device_id imx_phycore_ac97_of_dev_id[] = {
- {
.compatible = "phytec,imx27-pca100-ac97",.data = (void *)MX27_PCA100,- }, {
.compatible = "phytec,imx27-pcm043-ac97",.data = (void *)MX27_PCM043- }, {
/* sentinel */- }
+}; +MODULE_DEVICE_TABLE(of, imx_phycore_ac97_of_dev_id);
It seems like we ought to be able to describe the properties of the boards in this class rather than just enumerating the boards. What are the differences?
MODULE_AUTHOR("Sascha Hauer s.hauer@pengutronix.de"); -MODULE_DESCRIPTION("PhyCORE ALSA SoC driver"); +MODULE_DESCRIPTION(DRV_NAME ": PhyCORE ALSA SoC fabric driver");
Please don't make up terms like "fabric driver".