On Tue, Apr 4, 2017 at 7:45 PM, Daniel Baluta daniel.baluta@nxp.com wrote:
Add a separate function for deriving (sysclk, lrclk, bclk) when the clock is auto or pll.
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com
Just noticed this warnings:
sound/soc/codecs/wm8960.c:743:3: warning: 'best_freq_out' may be used uninitialized in this function [-Wmaybe-uninitialized] wm8960_set_pll(codec, freq_in, best_freq_out); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/codecs/wm8960.c:703:21: note: 'best_freq_out' was declared here int diff, closest, best_freq_out; ^~~~~~~~~~~~~ sound/soc/codecs/wm8960.c:806:46: warning: 'j' may be used uninitialized in this function [-Wmaybe-uninitialized] snd_soc_update_bits(codec, WM8960_CLOCK1, 0x7 << 6, j << 6); ~~^~~~ sound/soc/codecs/wm8960.c:802:44: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] snd_soc_update_bits(codec, WM8960_CLOCK1, 3 << 1, i << 1);
There is no way I can end up with these variable uninitialized. Will look more close and resend.
Thanks Charles for review.