At Mon, 10 Nov 2008 08:20:13 +0100, chri wrote:
Hi,
On Mon, Nov 10, 2008 at 7:50 AM, Takashi Iwai tiwai@suse.de wrote:
At Sat, 8 Nov 2008 08:44:16 +0100,
I don't think it's good to overwrite the global variables in this way.
I see. I just tried to keep the modifications minimal. Perhaps Ben Dooks, the author of the code, can suggest a better way to proceed. I will be happy to follow his suggestion.
OK.
And, what if playback and capture use the different formats in full duplex streams...?
I dont' think that this is possible on the S3C24{1,4}0 since the configuration registers are shared between playback and record path (so this applies to sample frequency too for example). I guess you are suggesting that given parameters should be checked against those of the currently playing stream to see if they are compatible?
Yes. Without a proper check and/or hw_param constraints, the driver thinks the streams are individual and allows apps to set up independent parameters, which may result in a hardware error.
Creating hw constraints sharing both playback and capture streams is a bit tricky and even racy. But, it'd be much better than nothing.
thanks,
Takashi