On Wed, Apr 28, 2010 at 6:52 PM, Benjamin Herrenschmidt benh@kernel.crashing.org wrote:
On Wed, 2010-04-28 at 17:13 -0500, Timur Tabi wrote:
On Wed, Apr 28, 2010 at 4:58 PM, Grant Likely grant.likely@secretlab.ca wrote:
The sound0 node needs a compatible value,
I knew I was forgetting something
the sound-device node should probably have one too.
The aliases, cpus, and memory node don't have a compatible property, and I was modeling the design after the aliases node.
aliases is a bad choice, it's very very special and is neither a device nor a virtual device, like chosen.
cpus is more of a match in your case.
In any case, I agree, you may not really need a compatible prop for the virtual device. In fact, Grant, do we really need an enclosing node like that ?
Mostly I'm concerned about 'polluting' the root node in a way that we'd regret later; but perhaps I'm being overly conservative. The sound node will still be uniquely identified by it's compatible property, so perhaps I'm fretting over nothing.
In any case, it's no big deal and shouldn't have much impact on the design.
Right, the point has been reached of quibbling over trivialities.
g.