15 Sep
2011
15 Sep
'11
3:21 p.m.
On Tue, Sep 13, 2011 at 12:59:35PM -0500, Timur Tabi wrote:
- iface = 0;
Random stylistic changes like this make review harder, especially when they're not mentioned in the changelog. In this case it's not clear from the diff alone that there are no other places where iface gets written to which are going to get trashed by the change and since it wasn't mentioned in the changelog it's not clear if the change was intentional or committed by mistake.
An important aspect of review is checking that the change being made actually do what they're supposed to do, unexpected additional stuff is a red flag - you have to work out if it's something the sender meant to include, what it's supposed to do and if it's a good idea.