Re: [alsa-devel] [RFC PATCH 08/40] soundwire: intel: remove BIOS work-arounds

On 25-07-19, 18:40, Pierre-Louis Bossart wrote:

the values passed by all existing BIOS are fine, let's use them as is. The existing code must have been needed only on early prototypes.

Thanks for this, I am applying this.

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

drivers/soundwire/intel.c | 11 ----------- 1 file changed, 11 deletions(-)

diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 51990b192dc0..c718c9c67a37 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -922,17 +922,6 @@ static int intel_prop_read(struct sdw_bus *bus) /* Initialize with default handler to read all DisCo properties */ sdw_master_read_prop(bus);

• /* BIOS is not giving some values correctly. So, lets override them */
• bus->prop.num_clk_freq = 1;
• bus->prop.clk_freq = devm_kcalloc(bus->dev, bus->prop.num_clk_freq,

• 			  sizeof(*bus->prop.clk_freq),
  

• 			  GFP_KERNEL);
  

• if (!bus->prop.clk_freq)

• return -ENOMEM;
  

• bus->prop.clk_freq[0] = bus->prop.max_clk_freq;
• bus->prop.err_threshold = 5;
• return 0;

}

-- 2.20.1