Hi Adam,
On Thu, Dec 17, 2020 at 2:33 PM Adam Ford aford173@gmail.com wrote:
On Thu, Dec 17, 2020 at 5:12 AM Geert Uytterhoeven geert@linux-m68k.org wrote:
CC alsa-devel
On Sun, Dec 13, 2020 at 7:38 PM Adam Ford aford173@gmail.com wrote:
With the newly added configurable clock options, the audio CODEC can configure the mclk automatically. Add the reference to the versaclock. Since the devices on I2C5 can communicate at 400KHz, let's also increase that too
Signed-off-by: Adam Ford aford173@gmail.com
Thanks for your patch!
--- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi @@ -424,13 +424,15 @@ &i2c0 {
&i2c5 { status = "okay";
clock-frequency = <100000>;
clock-frequency = <400000>; pinctrl-0 = <&i2c5_pins>; pinctrl-names = "default"; codec: wm8962@1a { compatible = "wlf,wm8962"; reg = <0x1a>;clocks = <&versaclock6_bb 3>;clock-names = "mclk";While the driver does get the (nameless) clock, the DT bindings lack any mention of a clocks property. It would be good to update the bindings.
Agreed. I'll push an update to add the clocks property.
Thanks!
Note that arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi and arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi (both by your hand) use "xclk" instead of "mclk"?
On the schematics for the two imx boards, it's labeled as xclk, so it was named as such. For this board, the schematic names it mclk. The driver doesn't care about the clock-names property, so I'll just remove them.
If there's a single clock, not using clock-names is fine. If you do use clock-names, the names should be clock-centric, not board-centric.
BTW, looking at the WM8962 datasheet, it's called "MCLK".
Gr{oetje,eeting}s,
Geert