Hi Geert,
Thank you for the review.
On Mon, Apr 25, 2022 at 1:49 PM Geert Uytterhoeven geert@linux-m68k.org wrote:
Hi Prabhakar,
On Fri, Apr 22, 2022 at 7:32 PM Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com wrote:
Drop unused macros SSIFSR_TDC and SSIFSR_RDC.
Reported-by: Nobuhiro Iwamatsu nobuhiro1.iwamatsu@toshiba.co.jp Signed-off-by: Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com
Thanks for your patch!
What does this fix? Is the real issue that there are 32 FIFO entries, and the TDC and RDC fields are 6 bits wide, while the mask uses 0x1f instead of 0x3f?
I was in two minds here as you have already spotted the masks are incorrect, instead of fixing the masks I choose to drop the macros itself as they were not used. Let me know what are your thoughts on this.
Cheers, Prabhakar
--- a/sound/soc/sh/rz-ssi.c +++ b/sound/soc/sh/rz-ssi.c @@ -59,9 +59,7 @@ #define SSIFSR_RDC_MASK 0x3f #define SSIFSR_RDC_SHIFT 8
-#define SSIFSR_TDC(x) (((x) & 0x1f) << 24) #define SSIFSR_TDE BIT(16) -#define SSIFSR_RDC(x) (((x) & 0x1f) << 8) #define SSIFSR_RDF BIT(0)
#define SSIOFR_LRCONT BIT(8)
Gr{oetje,eeting}s,
Geert-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds