Re: [alsa-devel] [PATCH] pinctrl: madera: Fix uninitialized variable issue in madera_mux_set_mux

Hi Charles,

I don't believe this would fully address the issue since if you initialise ret to -1 you will still drop into the if statement and you will use the reg variable which should also be uninitialised on that code path.

Feels like initialising to 0 would probably be better anyway since the code path looks like the case were you have n_pins == 0 and nothing really failed in that case just nothing needed to be done.

You're right. I got confused with another similar issue I fixed, recently.

I'll send v2 shortly.

Thanks for the feedback. -- Gustavo