Thank you very much for your review. I would like to discuss something with you
On 04/09/2023 12:14, krzysztof.kozlowski@linaro.org wrote:
On 04/09/2023 13:46, wangweidong.a@awinic.com wrote:
From: Weidong Wang wangweidong.a@awinic.com
Add a DT schema for describing awinic aw87390 audio amplifiers. They are controlled using I2C.
Thank you for your patch. There is something to discuss/improve.
+allOf:
- $ref: dai-common.yaml#
+properties:
- compatible:
- const: awinic,aw87390
- reg:
- maxItems: 1
No reset-gpios? Shouldn't this be just merged with awinic,aw88395 bindings?
Yes, this chip does not have reset-gpios, and the i2c address of this chip is different from the aw88395 chip.So I didn't merge it with awinic, aw88395.
Missing sound-dai-cells (const: 0 or 1)
Thank you very much. I'll add #sound-dai-cells
+required:
- compatible
- reg
+unevaluatedProperties: false
+examples:
- |
- i2c {
#address-cells = <1>;#size-cells = <0>;audio-codec@58 {compatible = "awinic,aw87390";reg = <0x58>;
Please add sound-dai-cells for the example to be complete.
Thank you very much, I will modify it in patch v2
Best regards, Weidong Wang