Re: [PATCH 10/10] ASoC: fsl: fsl_qmc_audio: Add support for non-interleaved mode.

1 Jul 2024


      Hi,
On Thu, 20 Jun 2024 10:42:57 +0200
Herve Codina herve.codina@bootlin.com wrote:
...
...
+static bool qmc_audio_access_is_interleaved(snd_pcm_access_t access)
+{

switch (access) {
case SNDRV_PCM_ACCESS_MMAP_INTERLEAVED:
case SNDRV_PCM_ACCESS_RW_INTERLEAVED:
return true;


default:
return false;


}

+};


The ';' at the end of the function should not be here and will be removed
in the next iteration.
Also, this function will be changed to
--- 8< ---
static bool qmc_audio_access_is_interleaved(snd_pcm_access_t access)
{
    switch (access) {
    case SNDRV_PCM_ACCESS_MMAP_INTERLEAVED:
    case SNDRV_PCM_ACCESS_RW_INTERLEAVED:
    	return true;
    default:
    	break;
    }
    return false;
}
--- 8< ---
Hervé