On Tue, Mar 2, 2021 at 1:31 AM Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:
In January, Intel kbuild bot and Arnd Bergmann reported multiple issues with randconfig. This patchset builds on Arnd's suggestions to
a) expose ACPI and PCI devices in separate modules, while sof-acpi-dev and sof-pci-dev become helpers. This will result in minor changes required for developers/testers, i.e. modprobe snd-sof-pci will no longer result in a probe. The SOF CI was already updated to deal with this module dependency change and introduction of new modules.
b) Fix SOF/SoundWire/DSP_config dependencies by moving the code required to detect SoundWire presence in ACPI tables to sound/hda.
Integration note: This patchset touches directories maintained by Vinod, Takashi and Mark in separate trees, and will impact additional changes to use the auxiliary bus in drivers/soundwire/. I can think of two options, both of which are fine:
- Mark merges the patches with Vinod and Takashi Acked-by tags, then
Mark provides an immutable tag to Vinod. 2. Vinod merges the patches with Mark and Takashi Acked-by tags, then Vinod provides an immutable tag to Mark
Acknowledgements: Thanks to Arnd for suggesting fixes and testing these patches with more randconfigs. Thanks to Vinod Koul for his feedback on the move of this common helper to sound/hda/
Hi Pierre-Louis,
I have not done as much randconfig tested recently as I used to, but since I ramped up the rate again after the merge window, I have unfortunately once more run into a variation of this problem, with CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE=m and CONFIG_SND_SOC_SOF_HDA_COMMON=y:
x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_interrupt_thread': hda.c:(.text+0x739): undefined reference to `sdw_intel_thread' x86_64-linux-ld: hda.c:(.text+0x764): undefined reference to `sdw_intel_process_wakeen_event' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_int_enable': hda.c:(.text+0x782): undefined reference to `sdw_intel_enable_irq' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_startup': hda.c:(.text+0x7ac): undefined reference to `sdw_intel_startup' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_sdw_process_wakeen': hda.c:(.text+0x7dc): undefined reference to `sdw_intel_process_wakeen_event' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_probe': hda.c:(.text+0xee1): undefined reference to `sdw_intel_probe' x86_64-linux-ld: sound/soc/sof/intel/hda.o: in function `hda_dsp_remove': hda.c:(.text+0xf7f): undefined reference to `sdw_intel_enable_irq' x86_64-linux-ld: hda.c:(.text+0xf8e): undefined reference to `sdw_intel_exit'
This only seems to appear very rarely, as I still did around 25000 randconfig builds since you merged the series, but this config does show the problem for any kernel version between the fix and the latest linux-next:
https://pastebin.com/raw/VCjcB3EU
I have only done the quick bisection but no analysis regarding what we may have missed back in March. I hope you can figure this out.
Arnd