On 03/01/2023 05:56, Padmanabhan Rajanbabu wrote:
Add device tree node support for sound card on Tesla FSD board
Signed-off-by: Padmanabhan Rajanbabu p.rajanbabu@samsung.com
arch/arm64/boot/dts/tesla/fsd-evb.dts | 37 +++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts index e2fd49774f15..ce726bddfb50 100644 --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts @@ -29,6 +29,43 @@ device_type = "memory"; reg = <0x0 0x80000000 0x2 0x00000000>; };
- sound {
compatible = "simple-audio-card";#address-cells = <1>;#size-cells = <0>;simple-audio-card,name = "FSD Audio Card";simple-audio-card,widgets ="Line", "Line Out",
I don't think you need to break the line after '='.
"Line", "Line In";simple-audio-card,routing ="Line Out", "LLOUT","Line Out", "RLOUT","MIC2L", "Line In","MIC2R", "Line In";status = "okay";
Why?
simple-audio-card,dai-link@0 {reg = <0>;format = "i2s";bitclock-master = <&tlv320aic3x>;frame-master = <&tlv320aic3x>;cpu0 {
Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
sound-dai = <&i2s_0 0>;};cpu1 {sound-dai = <&i2s_0 1>;};codec {sound-dai = <&tlv320aic3x>;system-clock-frequency = <33000000>;};
Best regards, Krzysztof