Re: [alsa-devel] [PATCH 17/22] ASoC: samsung: odroid: Add support for secondary CPU DAI

On 2/11/19 14:57, Krzysztof Kozlowski wrote:

...

static struct snd_soc_dai_link odroid_card_dais[] = {

•   {
  

•           /* Primary FE <-> BE link */
  

•           .codec_name = "snd-soc-dummy",
  

•           .codec_dai_name = "snd-soc-dummy-dai",
  

•           .ops = &odroid_card_fe_ops,
  

•           .name = "Primary",
  

•           .stream_name = "Primary",
  

•           .platform_name = "3830000.i2s",
  

Why exposing address as platform_name? I think it is not used so how about some friendlier name?

This entry is for selecting "PCM" (DMA) component for the link. For proper matching we need to use names of devices for which the dmaengine based PCM component is registered (with a call to samsung_asoc_dma_platform_register()).

We can't use platform_of_node because 2 PCM components ("3830000.i2s", "samsung-i2s-sec") are now associated with same DT node.

...

•   }, {
  

•           /* BE <-> CODECs link */
  

•   }, {
  

•           /* Secondary FE <-> BE link */
  

...

•           .platform_name = "samsung-i2s-sec",
  

...

•   }
  

};

-- Thanks, Sylwester