Re: [alsa-devel] [PATCH] alsa-lib: snd_device_name_hint misbehaving

On Sun, 1 Nov 2009, John Lindgren wrote:

• Remove erroneous snd_config_delete calls that cause later calls to

snd_pcm_open to fail.

It does not look good. Have you checked with valgrind if there are no memory leaks?

• Don't list card-independent PCM devices ("null" or PulseAudio, for

example) more than once even if multiple sound cards are installed.

• Add "ctl" to the list of device types that snd_device_name_hint can

search for.

• Cache the path to libasound.so within snd_dlopen rather than looking

it up with dladdr every call.

Please, split your changes to single patches. Thanks.

Jaroslav

----- Jaroslav Kysela perex@perex.cz Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.