Hi Ben,
My understanding is same as yours. Recently Realtek Audio expert Kailang (on copy) submitted a patch for Dock as the attached, are you asking the same thing? Looks like the issue is related to Dock model, there are many different Dock models, could you please let us know which specific dock model you mean? Thanks.
@Kailang, Do you have any suggestions or comments?
Thanks,
Peter Zhang \ 张福平, PMP ThinkPad & ThinkStation Linux Solutions Tel: (+86) 181-1611-8005 | Lenovo Shanghai
Linux for Those Who Do - http://www.lenovo.com/linux
-----Original Message----- From: Benjamin Berg [mailto:bberg@redhat.com] Sent: Wednesday, February 14, 2018 11:41 PM To: Takashi Iwai Cc: alsa-devel@alsa-project.org; Jaroslav Kysela; linux-kernel@vger.kernel.org; Peter FP1 Zhang Subject: Re: [PATCH] ALSA: hda/realtek: Limit mic boost on T480
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
On Wed, 2018-02-14 at 14:00 +0100, Takashi Iwai wrote:
On Wed, 14 Feb 2018 13:29:39 +0100, Benjamin Berg wrote:
The internal mic boost on the T480 is too high. Fix this by applying the ALC269_FIXUP_LIMIT_INT_MIC_BOOST fixup to the machine to limit the gain.
Signed-off-by: Benjamin Berg bberg@redhat.com Tested-by: Benjamin Berg bberg@redhat.com
Applying this quirk itself is OK, but just wonder whether this model has a docking station port. Recently we fixed the dock issue, and it required to apply ALC298_FIXUP_TPT470_DOCK.
I assumed that on the T480 and similar models the audio on the dock is connected through USB (the dock is USB-C + further pins), but I cannot confirm this myself right now as I only have a T480 currently.
I have now contacted Peter Zhang of Lenovo about this and also to check if other 80 series models may need the same fixup.
Benjamin
thanks,
Takashi
sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ce28f7ce64e6..8467ce3db767 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6510,6 +6510,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK), SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
- SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480",
ALC269_FIXUP_LIMIT_INT_MIC_BOOST), SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION), -- 2.14.3