Am 2021-03-11 12:05, schrieb Sameer Pujar:
It would work and initially I had similar patch, see [0] and related series. Suggestion is to always use "clocks" property with devices only.
I see. But again, I don't think it is correct to change the clock of the codec by default. What happens if this is for example a compatible = "fixed-clock"?
As you pointed out in the referred thread [0]. simple-audio-card has that clock and judging from the code it is exactly for this reason: to either change/enable it or not.
With this patch you'll switch that to "always change it". Therefore, shouldn't there be a dt flag to indicate wheter simple-audio-card/graph should be in charge of the codecs clock input?
And its fetching just the first clock, doesn't it? What happens if a codec has two clock inputs?
-michael
[0] https://patchwork.kernel.org/project/alsa-devel/patch/1611944866-29373-4-git...