13 Jun
2023
13 Jun
'23
12:59 p.m.
On Tue, Jun 13, 2023 at 12:34:45PM +0200, Takashi Iwai wrote:
Mark Brown wrote:
On Tue, Jun 13, 2023 at 09:45:11AM +0200, Takashi Iwai wrote:
This should be in _needs_sync().
I thought it's a different logic? regacahe_reg_needs_sync() checks only whether it's a default value, and other call paths already check regmap_writeable().
Yeah, but it feels like that's the reason we ran into this issue given that you'd expect _needs_sync() to check this too.
But I can put the check there instead if you still prefer, too.
It should avoid any similar issues in future.