On Mon, May 06, 2024 at 07:44:41AM +0000, Xu, Baojun wrote:
From: Andy Shevchenko andriy.shevchenko@linux.intel.com Sent: 30 April 2024 21:45 On Tue, Apr 30, 2024 at 02: 58: 10PM +0200, Takashi Iwai wrote: On Tue, Apr 30, 2024 at 02:58:10PM +0200, Takashi Iwai wrote:
On Tue, 30 Apr 2024 09:25:42 +0200, Baojun Xu wrote:
...
snd-hda-cs-dsp-ctls-objs := hda_cs_dsp_ctl.o snd-hda-scodec-component-objs := hda_component.o snd-hda-scodec-tas2781-i2c-objs := tas2781_hda_i2c.o +snd-hda-scodec-tas2781-spi-y := tas2781_hda_spi.o tas2781_spi_fwlib.o
A nitpicking: better to align with other lines (i.e. with *-objs instead of *-y).
I object this. The better approach is to have a precursor patch that switches to y over objs (the latter is for user space code / tools).
I also do not fully understand why set it as "y", as you know, I follow CONFIG_SND_HDA_SCODEC_TAS2781_I2C, as it do not set to "y".
While you see no side effects, the 'objs' is reserved for user space, while 'y' should be used in the kernel code.
See Documentation/kbuild/makefiles.rst "Composite Host Programs", mind the word "host" meaning.