Re: [alsa-devel] [PATCH] ASoC: soc-core: use GFP_KERNEL flag for kmalloc in snd_soc_cnew

On 20/08/11 04:03, Axel Lin wrote:

GFP_ATOMIC is not needed here, use GFP_KERNEL instead.

Signed-off-by: Axel Lin axel.lin@gmail.com

sound/soc/soc-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index ae93aa8..b6d8716 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1913,7 +1913,7 @@ struct snd_kcontrol *snd_soc_cnew(const struct snd_kcontrol_new *_template,

if (prefix) { name_len = strlen(long_name) + strlen(prefix) + 2;

• name = kmalloc(name_len, GFP_ATOMIC);
  

• name = kmalloc(name_len, GFP_KERNEL);
  

  if (!name) return NULL;

Acked-by: Liam Girdwood lrg@ti.com