Re: [alsa-devel] [PATCH] Fix for possible null pointer dereference in dma.c

Hi,

Rickard Strandqvist wrote:

There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist rickard_strandqvist@spectrumdigital.se

sound/soc/samsung/dma.c | 10 ++++++---- 1 fil ändrad, 6 tillägg(+), 4 borttagningar(-)

diff --git a/sound/soc/samsung/dma.c b/sound/soc/samsung/dma.c index dc09b71..b1f6757 100644 --- a/sound/soc/samsung/dma.c +++ b/sound/soc/samsung/dma.c @@ -115,17 +115,19 @@ static void dma_enqueue(struct snd_pcm_substream *substream) static void audio_buffdone(void *data) { struct snd_pcm_substream *substream = data;

• struct runtime_data *prtd = substream->runtime->private_data;

• struct runtime_data *prtd = NULL;

  pr_debug("Entered %s\n", __func__);

• if (prtd->state & ST_RUNNING) {

• if(substream)

Missing space.

Lothar Waßmann