Re: [alsa-devel] [PATCH] audio: sgtl5000: Add MicBias resistor support in DT

Hi Fabio,

2014-10-12 23:15 GMT+02:00 Fabio Estevam festevam@gmail.com:

On Sun, Oct 12, 2014 at 3:39 PM, Jean-Michel Hautbois jean-michel.hautbois@vodalys.com wrote:

...

•   if (np) {
  

•           if (!of_property_read_u32(np,
  

•                   "sgtl5000-micbias-resistor", &value)) {
  

•                   switch (value) {
  

•                   case 1:
  

•                           sgtl5000->micbias_resistor =
  

•                                   SGTL5000_MICBIAS_2K;
  

•                           break;
  

•                   case 2:
  

•                           sgtl5000->micbias_resistor =
  

•                                   SGTL5000_MICBIAS_4K;
  

•                           break;
  

•                   case 3:
  

•                           sgtl5000->micbias_resistor =
  

•                                   SGTL5000_MICBIAS_8K;
  

•                           break;
  

•                   default:
  

•                           sgtl5000->micbias_resistor =
  

•                                   SGTL5000_MICBIAS_OFF;
  

•                           dev_err(&client->dev,
  

•                                   "Unsuitable MicBias resistor\n");
  

The case 0 should SGTL5000_MICBIAS_OFF and the default should be SGTL5000_MICBIAS_4K.

You are right of course, second version sent. I have a patch wich adds MicBias voltage support too, but it will be on top of this one, is this a problem ?

Thanks, JM