Re: [PATCH v2 1/2] ALSA: pcm: rewrite snd_pcm_playback_silence()

On 20. 04. 23 13:33, Oswald Buddenhagen wrote:

The auto-silencer supports two modes: "thresholded" to fill up "just enough", and "top-up" to fill up "as much as possible". The two modes used rather distinct code paths, which this patch unifies. The only remaining distinction is how much we actually want to fill.

This fixes a bug in thresholded mode, where we failed to use new_hw_ptr, resulting in under-fill.

Top-up mode is now more well-behaved and much easier to understand in corner cases.

This also updates comments in the proximity of silencing-related data structures.

Signed-off-by: Oswald Buddenhagen oswald.buddenhagen@gmx.de

Looks much better. Thanks.

Reviewed-by: Jaroslav Kysela perex@perex.cz