10 Jan
2016
10 Jan
'16
1:52 p.m.
On Mon, Jan 04, 2016 at 02:29:34PM -0800, anish kumar wrote:
Signed-off-by: anish kumar yesanishhere@gmail.com
This looks mostly good, a couple of small things.
+static const struct snd_kcontrol_new max98926_mixer_controls[] = {
- SOC_DAPM_SINGLE("PCM Single", MAX98926_SPK_AMP,
MAX98926_INSELECT_MODE_SHIFT, 0, 0),- SOC_DAPM_SINGLE("PDM Single", MAX98926_SPK_AMP,
MAX98926_INSELECT_MODE_SHIFT, 1, 0),
Most of these mixer controls look like they're on/off switches (I'd expect them to be as mixer controls) so should have names ending in " Switch" as per ControlNames.txt so userspace can understand them.
+static const struct of_device_id max98926_of_match[] = {
- { .compatible = "maxim, max98926", },
There shouldn't be a space in the compatible string.