On Thu, 02 Jul 2020 21:35:41 +0200, Pierre-Louis Bossart wrote:
This cleanup touches a lot of old - and very old code for hardware designed in the late 1990s/early 2000s -, hence the RFC status. I mostly did dumb edits just to make warnings go away, suggestions and feedback welcome.
Pierre-Louis Bossart (23): ALSA: isa/gus: remove -Wmissing-prototypes warnings ALSA: isa/gus: remove 'set but not used' warning ALSA: pci/asihpi: remove 'set but not used' warnings ALSA: pci/asihpi: fix kernel-doc ALSA: pci/asihpi: remove 'set but not used' warning ALSA: pci/echoaudio: remove 'set but not used' warning ALSA: pci/aw2-saa7146: remove 'set but not used' warning ALSA: pci/ctxfi/ctatc: fix kernel-doc ALSA: pci/ctxfi: fix kernel-doc warnings ALSA: usb/line6: remove 'defined but not used' warning ASoC: pci/emu10k1: remove "set but not used' warnings ALSA: firewire: fix kernel-doc ALSA: pci/emu10k1: remove 'set but not used' warning ALSA: pci/korg1212: remove 'set but not used' warnings ALSA: pci/rme9652/hdspm: remove always true condition ALSA: pci/oxygen/xonar_wm87x6: remove always true condition ALSA: xen: remove 'set but not used' warning ALSA: pci/es1938: remove 'set but not used' warning ALSA: pci/fm801: fix kernel-doc ALSA: pci/via82xx: remove 'set but not used' warnings ALSA: pcmcia/pdaudiocf: fix kernel-doc ALSA: vx_core: remove warning for empty loop body ALSA: pci/au88x0: remove "defined but not used" warnings
Those look OK although __maybe_unused and __always_unused aren't always intuitive. At least better than spewing the warnings unnecessarily.
The line6 patch hasn't been applied yet because it might be clearer to be replaced with define instead. A similar argument may be applied to au88x0 code, but this is much uglier and I'd take a more straightforward fix by your patch.
So, now all but patch#10 are applied to for-next branch.
Thanks!
Takashi