On Mon, Mar 27, 2017 at 10:39:58AM +0200, Takashi Iwai wrote:
Intel SST driver spews an info message "FW Versoin xxxx" at each time the device gets initialized. Since it's triggered at each PM (or even runtime PM), it appears so ofetn, and rather becomes annoying than
^^ typo
useful.
This patch suppresses the superfluous messages by checking the currently loaded FW version with the previously loaded one.
Signed-off-by: Takashi Iwai tiwai@suse.de
sound/soc/intel/atom/sst/sst_ipc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c index 14c2d9d18180..20b01e02ed8f 100644 --- a/sound/soc/intel/atom/sst/sst_ipc.c +++ b/sound/soc/intel/atom/sst/sst_ipc.c @@ -236,7 +236,9 @@ static void process_fw_init(struct intel_sst_drv *sst_drv_ctx, retval = init->result; goto ret; }
- dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n",
- if (memcmp(&sst_drv_ctx->fw_version, &init->fw_version,
sizeof(init->fw_version)))
wont dev_info_once be better here? We are really not expecting a new version after suspend :)
dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n", init->fw_version.type, init->fw_version.major, init->fw_version.minor, init->fw_version.build);-- 2.11.1