18 Nov
2014
18 Nov
'14
4:29 p.m.
On Nov 18 2014 21:57, Clemens Ladisch wrote:
Takashi Sakamoto wrote:
In followed commits, dice driver is split into several files. For easily managing these files, this commit adds subdirectory and move file into the directory.
-// TODO: rx index +/* TODO: rx index */
event.dice_notification.type = SNDRV_FIREWIRE_EVENT_DICE_NOTIFICATION;
event.dice_notification.type =SNDRV_FIREWIRE_EVENT_DICE_NOTIFICATION;
count = min(count, (long)sizeof(event.dice_notification));
count = min_t(long, count, sizeof(event.dice_notification));-static void dice_bus_reset(struct fw_unit *unit) +static void dice_update(struct fw_unit *unit)
Please mention these changes in the commit message, or move them into a separate patch.
OK. The breaking-line and replacing with min_t is due to checkpatch.pl. The renaming is to apply the same way which I use on bebob/fireworks but is unnecessary.
As you mentioned, it's better to add a separete patch as a fix for them.
Thanks
Takashi Sakamoto