4 Apr
2011
4 Apr
'11
10:28 a.m.
At Sun, 03 Apr 2011 14:30:43 +0200, Torsten Schenk wrote:
Ok, fixed your two issues. Here the changelog and the patch again:
- control: digital thru added (for conversion optical<->tos)
- restructuring: samplerate, channel and streaming control moved to control.c
- firmware loader: loader now accepts all hardware versions of the device
- firmware loader: if firmware is already present it will be accepted if it is known to be working
- pcm: added support for s32_le sampleformat
- makefile: "experimental" dependency removed (tested and confirmed by users on http://sixfireusb.sourceforge.net)
- makefile: description updated
- bugfix: unsigned pcm_runtime.rate now never uses negative values (completion of signedness bug correction submitted by Dan Carpenter)
- bugfix: firmware leak fixed if error occurs (already submitted by Jesper Juhl but not in kernel yet)
Thanks. But, as you see, there are too many changes done in a single patch. Could you split the changes into several incremental patches? In principle, one patch should contain one change. Of course, some trivial changes can be merged, but the above is way too much.
Takashi