Re: [alsa-devel] [patch] ALSA: hda/realtek - cleanup a condition

On 02/06/2012 08:52 AM, Dan Carpenter wrote:

Sparse complains that "spec->multiout.dac_nids" is a pointer.

sound/pci/hda/patch_realtek.c:2321:37: error: incompatible types for operation (>) sound/pci/hda/patch_realtek.c:2321:37: left side has type unsigned short const [usertype] *dac_nids sound/pci/hda/patch_realtek.c:2321:37: right side has type int

I think the intent here was just to check if it was non-NULL, but please double check.

It could also have meant to be "if (spec->multiout.num_dacs > 0)", but either way, it seems very unlikely that the condition is false.