On 3/22/20 11:37 PM, Tanu Kaskinen wrote:
On Thu, 2020-03-19 at 14:27 -0500, Pierre-Louis Bossart wrote:
Also, we need to consider this to have the whole picture:
Tanu (the pulseaudio maintainer) has also good question how to ensure, that the stream can be re-used for the multiple devices. Actually, PA does not re-open PCM device when the PCM device name and parameters are similar for the switched devices. I also think that this is also missing in the UCM specification to resolve this requirement. Usually, the stream transfer mechanism is separate from the routing control. But I can assume, that we may have the hardware which will need extra setup for the streaming (not routing) when the devices are switched.
I think that adding something like "PlaybackStream" to "PlaybackPCM" for the stream identification might be sufficient to cover those cases. So, keep "PlaybackPCM" usage and if "PlaybackStream" exists, use this value to determine the stream identification. Similar situation is for the capture direction, of course.
I am not sure I understand the notion of stream and stream transfer. Is there a pointer to this so that I could understand the problem statement?
Example:
Device1: ... some enable sequence ... PlaybackPCM "hw:0" PlaybackStream "DAC1"
Device2: ... another enable sequence ... PlaybackPCM "hw:0" PlaybackStream "DAC2"
In this case, PCM names for alsa-lib are same, but there's a different setup to route signal to different DAC which cannot be executed without the PCM re-open task (when the PCM "hw:0" is active).
I see, thanks for the explanations.
Indeed in the past we had similar routing issues that required re-configuration and possibly stopping the stream or changing clock settings/ownership.
However I would argue that the solution is more to define additional steps than add additional qualifiers in the enable/disable steps.
FWIW in the Android solutions from Intel, we had 5 steps for each routing change:
- mute old paths
- disable streaming on old paths
- configure new paths
- enable streaming on new paths
- unmute new paths
At each step we could describe what actions were necessary or if the step could be skipped. That allowed us to deal nicely with transitions, I don't think we encountered any case that these steps couldn't handle.
It seems that Pierre understood the idea behind the PlaybackStream proposal, but I still don't understand what problem it's solving. Is the problem that PulseAudio doesn't reopen the stream when it should? So in the example, there are two DACs, and selecting the DAC is done via the mixer, but the switch can't be done while the stream is open? I haven't seen such devices, so this is a new problem to me.
It's not very common but does happen. I had a laptop where one mixer control would only take effect if the PCM was already open. In phones the clock ownership may change during a voice call, and handling of alert streams could involve different PCMs or had to be held while the clocks were changed.
The "problem" that I brought up earlier in the device variant discussion was different: the PulseAudio profile scheme that Jaroslav proposed would mean that PulseAudio would always reopen the stream even when it would be sufficient to just change a setting in the mixer. I don't think this is a significant problem. When changing routing, it's not important to keep the stream running without any interruption.
Can you stop/restart the PCM device without impacting apps though?
The 5-step process that Pierre described is good, in particular it allows setting the volume at the right time (currently PulseAudio doesn't follow that process, and as a result there can be volume glitches when changing routing). To me it seems that following this process is already possible without changes to UCM, so I don't know what Pierre meant by defining additional steps.
I meant instead of having just an 'enable' and 'disable' step in UCM, have additional ones done prior to streaming and after streaming. The 'Enable' handles too many things at the moment IMHO, it's both routing, streaming and mute.