On Fri, Apr 7, 2017 at 10:27 AM, Linus Walleij linus.walleij@linaro.org wrote:
On Wed, Apr 5, 2017 at 12:07 PM, Richard Fitzgerald rf@opensource.wolfsonmicro.com wrote:
This patch adds a header file of register definitions for Cirrus Logic "Madera" class codecs. These codecs are all based off a common set of hardware IP so have a common register map (with a few minor device-to-device variations). These are complex devices with a large mber of features and so have a correspondingly large register set. The registers.h file has been auto-generated from the hardware register definitions, stripped down to only registers we need to access from the driver.
Signed-off-by: Richard Fitzgerald rf@opensource.wolfsonmicro.com
This: include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++++++++++++++++
Get included in all subdrivers I suppose?
So you are broadcasting 8800+ lines into every subdriver across the entire kernel.
Just the time spent in the preprocessor parsing this will affect compilation time.
Or maybe this is a necessary sacrifice to get the regmap cache centralized in MFD. I don't know. I feel stupid.
I guess I should focus on "my" subsystems...
Yours, Linus Walleij