On Thu, Feb 20, 2020 at 12:46:57PM -0600, Dan Murphy wrote:
On 2/20/20 12:45 PM, Mark Brown wrote:
Is there a reason not to use the chip default here? Otherwise this looks good.
Chip default is set to 0dB full blast+ 0x40400000. This sets the volume to -110dB.
OK... that's a policy decision the same as all other volume changes and so shouldn't be done by the driver - as ever we don't know how the system is set up and what values make sense and keeping things out of the driver means we don't end up with competing system integration decisions causing changes in the driver. The system may have an external amplifier they prefer to use for hardware volume control, may prefer to do entirely soft volume control in their sound server or something like that.