Re: [alsa-devel] [PATCH 02/20] OMAP: McBSP: Wakeups utilized

On Thu, Jul 30, 2009 at 08:56:02PM +0200, ext Jarkko Nikula wrote:

On Thu, 30 Jul 2009 15:49:25 +0300 Eduardo Valentin eduardo.valentin@nokia.com wrote:

...

--- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -257,6 +257,23 @@ int omap_mcbsp_request(unsigned int id) clk_enable(mcbsp->iclk); clk_enable(mcbsp->fclk);

+#ifdef CONFIG_ARCH_OMAP34XX

• /*

I'm sure there is a way to avoid all of these added ifdefs in this patch and in patches 7 and 8 as well.

hmmm.. these ifdef's are required because I've put the extra field (for 34xx only) inside an ifdef on their declaration in mcbsp.h. We can remove it there, but will leave a few extra bytes on !omap3xx binaries.

-- Jarkko