On Tue, Apr 24, 2018 at 11:49 AM, Srinivas Kandagatla srinivas.kandagatla@linaro.org wrote:
Thanks for the review.
On 24/04/18 17:25, Rob Herring wrote:
On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandagatla@linaro.org wrote:
From: Srinivas Kandagatla srinivas.kandagatla@linaro.org
Add devicetree bindings documentation file for Qualcomm apq8096 sound card.
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
.../devicetree/bindings/sound/qcom,apq8096.txt | 76 ++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8096.txt
diff --git a/Documentation/devicetree/bindings/sound/qcom,apq8096.txt b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt new file mode 100644 index 000000000000..37e23d926b95 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,apq8096.txt @@ -0,0 +1,76 @@ +* Qualcomm Technologies APQ8096 ASoC sound card driver
+This binding describes the APQ8096 sound card, which uses qdsp for audio.
+- compatible:
Usage: requiredValue type: <stringlist>Definition: must be "qcom,apq8096-sndcard"+- qcom,audio-routing:
Usage: OptionalValue type: <stringlist>Definition: A list of the connections between audio components.Each entry is a pair of strings, the first being theconnection's sink, the second being the connection'ssource. Valid names could be power supplies, MicBiasof codec and the jacks on the board:Please list out valid values here.
I can list the values for the HDMI playback use-case, but the list would grow as we start adding wcd9335 codec support.
If you don't have the values, then how does one validate a DT is correct?
Honestly, a single property like this seems insufficient to describe audio routing.
+= dailinks +Each subnode of sndcard represents either a dailink, and subnodes of each +dailinks would be cpu/codec/platform dais.
+- link-name:
Not a standard property, but I guess that sneaked in with the 8016 binding...
Yes, I followed 8016 bindings.
Am happy to prefix this with qcom if that makes more sense.
I'd just leave it to be consistent.