On Fri, Jul 18, 2008 at 12:29:37AM -0600, Grant Likely wrote:
On Mon, Jul 14, 2008 at 12:45:55PM +0100, Mark Brown wrote:
On Sat, Jul 12, 2008 at 02:39:39AM -0600, Grant Likely wrote:
This configuration is also exposed via a sysfs file, including some of the configurability. Exposing the information via sysfs isn't a particular problem but allowing it to be written to without going through ALSA seems wrong.
All the written bit does is trigger the keyclick event. It doesn't adjust the parameters in any way.
That should be OK for now but we ought to work out a way of doing this via an ALSA control so it can be standardised over the devices that support it. I can't see anything suitable currently, though.
+#if defined(CONFIG_SND_SOC_OF)
- /* Tell the of_soc helper about this codec */
- of_snd_soc_register_codec(&aic26_soc_codec_dev, aic26, &aic26_dai,
spi->dev.archdata.of_node);+#endif
CONFIG_SND_SOC_OF could be a module - this needs to also check for it being a module.
Doesn't #if defined() match on both static and module selection?
Sadly not.