Hi Vinod,
Just noticed that this patch is similar with this one for crecord
http://git.alsa-project.org/?p=tinycompress.git;a=commit;h=e8e36567438c 16a5121943205a0cd8c63924d0d8
So, I think we can remove the RFC tag :).
thanks, Daniel. On Lu, 2018-11-05 at 14:23 +0000, Daniel Baluta wrote:
cplay first writes frag * fragment_size and then it only writes one fragment at a time.
This means for example than if the user supplied a buffer_size it will only be used for the first write.
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com
I noticed this while investigating why cplay prints buffer_size as 0 when not specified as command line argument to cplay.
I also noticed that cred always reads frag * frament_size, so I think this patch should be OK, but marking it as RFC to get your thoughts.
src/utils/cplay.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/utils/cplay.c b/src/utils/cplay.c index 2a52b52..b016f52 100644 --- a/src/utils/cplay.c +++ b/src/utils/cplay.c @@ -435,15 +435,15 @@ void play_samples(char *name, unsigned int card, unsigned int device, }; if (verbose) printf("%s: Opened compress device\n", __func__);
- size = config.fragment_size;
- buffer = malloc(size * config.fragments);
- size = config.fragments * config.fragment_size;
- buffer = malloc(size);
if (!buffer) { fprintf(stderr, "Unable to allocate %d bytes\n", size); goto COMP_EXIT; } /* we will write frag fragment_size and then start */
- num_read = fread(buffer, 1, size * config.fragments, file);
- num_read = fread(buffer, 1, size, file);
if (num_read > 0) { if (verbose) printf("%s: Doing first buffer write of %d\n", __func__, num_read); @@ -459,7 +459,7 @@ void play_samples(char *name, unsigned int card, unsigned int device, } } printf("Playing file %s On Card %u device %u, with buffer of %lu bytes\n",
name, card, device, buffer_size);
name, card, device, size);printf("Format %u Channels %u, %u Hz, Bit Rate %d\n", codec.id, codec.ch_in, codec.sample_rate, codec.bit_rate);