On Thu, 26 Jul 2018 16:51:55 +0200, kbuild test robot wrote:
Hi Pierre-Louis,
I love your patch! Yet something to improve:
[auto build test ERROR on sound/for-next] [also build test ERROR on v4.18-rc6 next-20180725] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pierre-Louis-Bossart/ALSA-memalloc-... base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=alpha
All errors (new ones prefixed by >>):
In file included from include/sound/pcm.h:27:0, from sound/core/pcm_iec958.c:11: include/sound/memalloc.h: In function 'snd_sgbuf_aligned_pages':
include/sound/memalloc.h:75:17: error: 'PAGE_SIZE' undeclared (first use in this function); did you mean 'TASK_SIZE'?
return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; ^~~~~~~~~ TASK_SIZE
OK, we need to include <asm/page.h> in this header file.
Pierre, care to resend with the fix?
thanks,
Takashi