16 Aug
2019
16 Aug
'19
8:22 a.m.
On Wed, 14 Aug 2019 at 11:30, Mark Brown broonie@kernel.org wrote:
On Wed, Aug 14, 2019 at 08:08:41AM +0200, codekipper@gmail.com wrote:
From: Marcus Cooper codekipper@gmail.com
Codecs without a control connection such as i2s based HDMI audio and the Pine64 DAC require a different amount of bit clocks per frame than
This isn't a universal property of CODECs without a control, and it's something that CODECs with control can require too.
ACK
return sun4i_i2s_set_clk_rate(dai, params_rate(params),
params_width(params));
i2s->tdm_slots ?i2s->slot_width : params_width(params));Please write normal conditional statements unless there's a strong reason to do otherwise, it makes things more legible.
ACK
+static int sun4i_i2s_set_dai_tdm_slot(struct snd_soc_dai *dai,
unsigned int tx_mask,unsigned int rx_mask,int slots, int width)+{
struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);i2s->tdm_slots = slots;i2s->slot_width = width;return 0;+}
No validation of the parameters here?
ACK Thanks, CK