Re: [alsa-devel] [PATCH 4/8] ASoC: AMD: added condition checks for CZ specific code

On Fri, Jun 23, 2017 at 12:35:02PM -0400, Alex Deucher wrote:

Reviewed-by: Alex Deucher alexander.deucher@amd.com

index dcbf997..e48ae5d 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -34,6 +34,8 @@

#define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS) #define MIN_BUFFER MAX_BUFFER +#define CHIP_STONEY 14 +#define CHIP_CARRIZO 13

These defines are being added in the middle of a file but CHIP_STONEY is also used in another file in the previous patch (and apparently extensively throughout the DRM driver already). This is obviously not good, we shouldn't have multiple copies of the definition.

• } else {

• if (adata->asic_type == CHIP_CARRIZO) {
  

• 	for (bank = 1; bank <= 4; bank++)
  

• 		acp_set_sram_bank_state(adata->acp_mmio, bank,
  

• 		false);
  

I'm not seeing any poweroff cases for other chips being added, and again switch statements please.