-----Original Message----- From: Krzysztof Kozlowski krzk@kernel.org Sent: Friday, December 5, 2025 4:32 PM To: Oder Chiou oder_chiou@realtek.com Cc: cezary.rojewski@intel.com; broonie@kernel.org; lgirdwood@gmail.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; perex@perex.cz; linux-sound@vger.kernel.org; devicetree@vger.kernel.org; alsa-devel@alsa-project.org; Flove(HsinFu) flove@realtek.com; Shuming [范 書銘] shumingf@realtek.com; Jack Yu jack.yu@realtek.com; Derek [方德 義] derek.fang@realtek.com Subject: Re: [PATCH v8 2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for ALC5575
External mail : This email originated from outside the organization. Do not reply, click links, or open attachments unless you recognize the sender and know the content is safe.
On 05/12/2025 09:31, Krzysztof Kozlowski wrote:
- reg:
- maxItems: 1
You listed so many "impressive" and "rich" features that for sure this is incomplete.
Please post complete bindings for "impressive" device.
You miss supplies, you miss all the AI related hype (no clue what that would be, but for sure NPU feels like needing remoteproc or at least some other way to communicate). We all know that AI is power hungry, so it is impossible to run it without electricity (thus supplies).
Also two standard nits, in case I did not ask about them before:
A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/b... ndings/submitting-patches.rst#L18
The subject will be change to ASoC: dt-bindings: realtek,rt5575: add support for ALC5575
Please organize the patch documenting the compatible (DT bindings) before the patch using that compatible. See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/b... ndings/submitting-patches.rst#L46
I will reorder the patches so that the DT bindings come first.
Thanks.