On Thu, 23 Jul 2015 08:25:21 +0200, David Henningsson wrote:
On 2015-07-23 08:17, David Henningsson wrote:
I'm about to go on vacation so it would be good to get some closure here. If you both prefer this setup, how about I remove "struct i915_audio_hotplug_info" for now? We will then have:
const struct i915_audio_component_audio_ops { void (*hotplug_notify)(struct hdac_bus *); }Sorry, it would look like this:
const struct i915_audio_component_audio_ops { void (*hotplug_notify)(struct hdac_bus *, int port, intport_mst_index); }
...to indicate what port needs updating.
Yes, I think this is simpler.
A remaining question is whether it should be notified to bus or codec. In the latter case, we need to allow registering the audio codec after binding the component.
I find the codec can be a bit better, as this is directly targeted (while for bus you need to look through the codec list). But it's just a minor difference, and I don't mind so much about this, if there is any other difficulty by that move.
thanks,
Takashi