On Sat, 08 Aug 2015 18:23:35 +0200, Adrian Knoth wrote:
Signed-off-by: Adrian Knoth <aknoth@google.com>
This should be the one before the last patch in the series.
diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig index edfc1b8..9b62479 100644 --- a/sound/pci/Kconfig +++ b/sound/pci/Kconfig @@ -607,6 +607,27 @@ config SND_HDSPM To compile this driver as a module, choose M here: the module will be called snd-hdspm.
+config SND_MADIFX + tristate "RME Hammerfall DSP MADI FX" + select SND_HWDEP + select SND_RAWMIDI + select SND_PCM + help + Say Y here to include support for RME Hammerfall DSP MADI FX + soundcards. + + To compile this driver as a module, choose M here: the module + will be called snd-madifx. + +if SND_MADIFX +config SND_MADIFX_BROKEN + bool "Include broken WIP code" + help + This option is intended for developers, most people should say N + here. It enables work-in-progress code that's not yet usable from + userspace. +endif # SND_MADIFX_BROKEN
Just use depends on in stead of if. And is this broken or not usable? In the latter case, using a word "BROKEN" is rather confusing because it means that the kernel part is ready. OTOH, if it's really a broken code, including it in the upstream tree should be avoided. thanks, Takashi