On 09/09/2012 06:03 AM, Clemens Ladisch wrote:
sgiurgiu11@gmail.com wrote:
From: Sergiu Giurgiu sgiurgiu11@gmail.com
Signed-off-by: Sergiu Giurgiu sgiurgiu11@gmail.com
Many thanks for writing this patch! However, please mention which features work, don't work, or aren't tested.
I didn't see where (how) could i specify the mail body when using git send-email, I'll look/study further so that in the future I’ll have more context around the pieces of code written. Maybe the git commit comment??
What works/has been tested: - play sound - volume controls (mute also)
Since I only have 2 speakers, I cannot say anything about its 5.1 support. What "should" work: everything that works for Xonar DS. As far as I can tell, DS and DSX are the same card the only difference being PCI vs PCIE. The fact that it was only required such a minor change to make it play sounds, makes it very likely. It has been running for the last 2 days on my PC.
+++ b/mirror/sound/pci/oxygen/xonar_wm87x6.c
+static const struct oxygen_model model_xonar_dsx = {
- .shortname = "Xonar DSX",
...This structure is almost the same as model_xonar_ds; please merge them. (See xonar_cs43xx.c for an example.)
The 2 structures are the same since we are talking about the same chip. I'll take a look in the file you've mentioned to see if there's a better way. I've started with the second struct since i had no idea what changes would be required, but yes, other than the name nothing is different.
Regards, Clemens
All the best, Sergiu.